Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization] - Custom visitor, index tree, scoped thread #86

Merged
merged 6 commits into from
Mar 20, 2023

Conversation

solidiquis
Copy link
Owner

@solidiquis solidiquis commented Mar 19, 2023

Bug Fixes

Major changes

  • Tree is now a wrapper around an index tree as opposed to a heap-based tree structure where every Node holds a Vec of its children. The benefits of this are less indirection and therefore less trips to the heap as well as better CPU cache locality.
  • Printing of the Tree is now done iteratively as opposed to recursively.

To-Do

[] - Benchmark against original implementation

@solidiquis solidiquis marked this pull request as draft March 19, 2023 17:08
@solidiquis solidiquis marked this pull request as ready for review March 20, 2023 09:06
@solidiquis solidiquis merged commit 72ff2fe into master Mar 20, 2023
@solidiquis solidiquis deleted the optimization/arena-tree branch April 14, 2023 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant