Add support for generating shell completions #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solidiquis
requested changes
Mar 17, 2023
src/main.rs
Outdated
| @@ -28,6 +29,12 @@ fn main() -> ExitCode { | |||
| fn run() -> Result<(), Box<dyn std::error::Error>> { | |||
| tree::ui::init(); | |||
There was a problem hiding this comment.
Would you mind moving this piece of code to below if let Some(shell) = ctx.completions { ... }? Just because there's no need to initialize all the UI code when setting up completions.
Brezak
force-pushed
the
shell-completions-as-flag
branch
from
dd83e55 to
f06b533
Compare
solidiquis
approved these changes
Mar 17, 2023
|
Thanks for this @Brezak! Will be included in next minor release sunday :] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #79
Adds a
--completionsflag for generating shell completions