Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(readme): add scoop, minor changes #80

Merged
merged 1 commit into from
Mar 17, 2023

Conversation

fawni
Copy link
Contributor

@fawni fawni commented Mar 17, 2023

closes #36

merged into the main scoop repo as of ScoopInstaller/Main#4560

note that the v1.5.2 release for windows has an inconsistent name with the previous releases or other binaries in the same release: et-1.5.2... as opposed to et-v1.5.2... which currently breaks auto-updating in the scoop package. looking at the workflow this seems like a bug and not an intentional change, but if it is intentional and will be used in future releases i will make a pr to adapt the scoop package. if it isn't intentional however, could you change the binary name in the v1.5.2 release so scoop can auto-update from v1.4.1 to v1.5.2?

@solidiquis
Copy link
Owner

Thank you a bunch for doing this! And yes I just renamed the binary, that was my fault. There is a current bug with windows not being able to read the tag number so I usually just go in and rename it manually which caused the error. (See #18 for more context). As I'm not super familiar with scoop, just wondering if there's anything I need to do on my end to bump the erdtree version on scoop whenever I do another release?

@solidiquis solidiquis merged commit f566dc9 into solidiquis:master Mar 17, 2023
@fawni
Copy link
Contributor Author

fawni commented Mar 17, 2023

just wondering if there's anything I need to do on my end to bump the erdtree version on scoop whenever I do another release?

nope! it will auto update with each release (provided that the name stays consistent)
here is how it auto-updates

@solidiquis
Copy link
Owner

Amaze! Given how busy I am with work and life things I wouldn't have been able to get to this for awhile so thank you for taking charge on this <333

@NormTurtle
Copy link

🚀 good

@fawni fawni deleted the chore/add-scoop branch March 17, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Request] scoop manifest for window ?
3 participants