allow dirs-first flag to work regardless of order

[fawni]

closes #65

[xiuxiu62]

I checked out your branch and can confirm it works. I'm working on a dirs-last implementation, but thought it might make more sense to roll the two into a single optional sub-command. Something like DirectoryOrdering { First, Last }, with short -D and long --dir-order.

[fawni]

i changed the sort type from Option<SortType> to SortType and set the default value to SortType::None which i think makes the most sense for this implementation. however, this assumes that SortType::None is okay, is it okay? this means that it can be explicitly specified by users: et -s none and i do not know if that is good design or not

[bryceberger]

Yeah, that implementation makes sense. Seems fine to let "sorting by none" be an explicit option, since it's the default. If someone "overrides" the default with an alias (or a config file? not 100% sure how those work with defaults), this gives them a chance to override their default.

That all said, this was an option in 1.3 and was later removed (in 5ea5730). Not sure why / if it was intentional, but there don't seem to be downsides to me.

[solidiquis]

@bryceberger I didn't have a great reason to remove it. It just felt weird at the time to have a None variant instead of just using an Option but in light of this discussion I am in agreement.

Thanks @fawni for the contribution! If you wouldn't mind just taking care of the minor merge conflict that'd be awesome.

[solidiquis]

Thanks @fawni for the contribution! <3