Add option to suppress size from being printed #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solidiquis
requested changes
Mar 7, 2023
|
|
||
| /// Don't show size; disabled by default | ||
| #[arg(long)] | ||
| pub suppress_size: bool, |
There was a problem hiding this comment.
Could you reword to "Omit disk usage from output; disabled by default"?
There was a problem hiding this comment.
No problem, updated in both locations.
README.md
Outdated
| @@ -62,6 +62,7 @@ Options: | |||
| -l, --level <NUM> Maximum depth to display | |||
| -n, --scale <NUM> Total number of digits after the decimal to display for disk usage [default: 2] | |||
| -s, --sort <SORT> Sort-order to display directory content [default: none] [possible values: name, size, size-rev, none] | |||
| --suppress-size Don't show size | |||
|
Anything special I need to do to get the same test locally as in CI? When I run the tests locally they all pass. |
solidiquis
requested changes
Mar 7, 2023
tests/suppress_size.rs
Outdated
| #[test] | ||
| fn suppress_size() { | ||
| assert_eq!( | ||
| utils::run_cmd(&["--suppress-size", "tests/data"]), |
There was a problem hiding this comment.
So the test is failing because the output isn't deterministic unless you provide the --sort option. I recommend adding --sort name to get deterministic output so that tests pass :]
solidiquis
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Thanks @sanders41 for the contribution! Will include in next minor version bump this weekend :]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #8