Early return UID/GID if nonexistent #190
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a UID/GID doesn't exist on the system, just print the value of it instead of hard crashing.
|
Hey @nwoythal! Thanks for filing an issue and for the submission! Really appreciate it, however, returning the UID as a string isn't the desired behavior in the case of an invalid user or group so I decided to return an error instead in this PR. Thanks again though for finding this one! If you're interested in learning Rust or contributing further feel free to shoot me a discord message! You can find my discord on my Github profile. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a UID/GID doesn't exist on the system, just print the value of it instead of hard crashing.
(Hopefully) fixes #189