Unify Glob arguments into one Argument

[KP64]

This comes at a degradation of usage friendliness.
Before:

erd -- --pattern <Pattern> --(glob | iglob)

After:

erd -- --pattern <Pattern> --glob (sensitive | insensitive)

It is worth it, though, since it is now harder to mess up the Argument checking in the Source Code.
Enums are exhaustive, after all.

The usage degradation could be minimized by using a shortcut for “--glob”. “-G” or “-g” for example.

[solidiquis]

Hmm I like where this is going but I feel like --glob should by default use case-sensitive searching without you needing to specify that it's case-sensitive. This is the behavior in similar programs such as ripgrep and fd and I wouldn't want to stray too far from what they're doing. What do you think?

[KP64]

Hmm I like where this is going but I feel like --glob should by default use case-sensitive searching without you needing to specify that it's case-sensitive. This is the behavior in similar programs such as ripgrep and fd and I wouldn't want to stray too far from what they're doing. What do you think?

I've had this thought too, but I don't really know how to do it, even after looking into it.
I've looked into the documentation of clap and couldn't find anything. This leaves me wondering if it is even possible.
Could you provide me with a reference on how to do it (if even possible)?

fd has implemented their Glob as a boolean, just like we did at the beginning.

#[arg(
  long,
  short = 'g',
  conflicts_with("fixed_strings"),
  help = "Glob-based search (default: regular expression)",
  long_help
)]
pub glob: bool,

[solidiquis]

I've had this thought too, but I don't really know how to do it, even after looking into it.

I'm not really sure off the top of my head how to do this nicely with clap's derive API. We might have to do some manual parsing of the argument which I'm not much a fan of.

One argument i found for keeping iglob and glob is to make use of argument grouping like so. The group keyword argument might allow us to have iglob and glob be mutually exclusive with one another. Let me know what you think.

[KP64]

Seems good to me 👍

[KP64]

Should I close this PR then, or adjust the Code to your suggestion?

[solidiquis]

If you wouldn't mind changing to my suggestion that'd be great. I like some of the other code refactors in this PR :]

[KP64]

If you wouldn't mind changing to my suggestion that'd be great. I like some of the other code refactors in this PR :]

Alright, everything should be ready to go now.
One last thing btw. I've added new sorting methods (in case you haven't seen). Truth be told, I forgot to switch branches and didn't realize that these changes went into this PR, haha.
#158 Should be closed by these Changes.

[solidiquis]

Oh nice! Thanks for taking care of #158! Much appreciated. Would you mind just fixing the merge conflicts? Once that's done and I run the workflows I'll get this merged in after breakfast :D

[solidiquis]

Merging in a bit! Thanks for your help as always!