Add option to filter files using glob patterns #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These args used to build `Overrides`, which are passed to the `WalkBuilder` which is used to traverse directories. Because the glob patterns may be invalid, parsing the `Clargs` is now fallible.
|
This looks good! Do tests pass for you locally by chance? It is failing here |
|
Yes, they are passing locally. The globbing seems to work correctly, but the output lists the files in a different order. I added |
|
Fantastic, thanks for the feature add! I will include it in the release hopefully later this week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10
Three new flags were added:
-g/--glob, which allows specifying a glob pattern to use when filtering files--iglob, which is like--glob, but the pattern is case insensitive--glob-case-insensitive, which makes all--globto behave like--iglobI couldn't think of a good way to test this under tree/test.rs (because the big code change is in cli), so the tests for this feature were added as E2E tests under
/tests. They executeerdtreeusingcargowith the given args, and compare the output (with ansi escapes stripped) against string literals (de-intended usingindoc).Because the glob pattern may be invalid (see https://docs.rs/globset/latest/globset/#syntax), parsing
Clargsis now fallible (done by replacing the implementation ofFrom<&Clargs>withTryFrom<&Clargs>.