Application of Clippy lints and possible improvement in development ergonomics #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Clippy all Clippy lints and set them to warning. Some of the lints are Fixed now while some have been only silenced.
Since Rust version 1.67.0 Crossbeam has been merged into the standard library. This makes the use of the external crate unnecessary. (rust-lang/rust#93563)
The addition of thiserror allows for more ergonomics while writing code for error States.
Updated "rust-version" in Cargo.toml since Crossbeam has been merged into std in rust version 1.67.0
KP64
changed the title
|
Beautiful, thank you for doing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have added Clippy into the project and applied a few of the fixes while silencing other ones.
I Also removed the crossbeam crate, since it's merged into the standard library since Rust 1.67.0.
To improve ergonomics through elimination of boilerplate code and simplification of adding new errors, I have added the thiserror crate.