Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Unable to replay when status is stopped #449

Merged
merged 1 commit into from
Jan 29, 2024

Conversation

Virczz
Copy link
Contributor

@Virczz Virczz commented Nov 7, 2023

Fixed not working if trying to replay when playback state is stopped.

@flowkscai
Copy link

Is there a maintainer who can help review this PR?

@illia-romanenko
Copy link
Collaborator

Hey 👋, Since it's marked as Draft - we didn't check it yet. If it's ready for review - can we please update it and make not Draft?

@flowkscai
Copy link

Hey 👋, Since it's marked as Draft - we didn't check it yet. If it's ready for review - can we please update it and make not Draft?

My apologies, didn't notice this. Many thanks for the prompt reply.

@Virczz Virczz marked this pull request as ready for review January 26, 2024 06:15
Copy link
Collaborator

@illia-romanenko illia-romanenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@illia-romanenko illia-romanenko merged commit 4bb85a9 into solid-software:master Jan 29, 2024
@shahindadashov
Copy link

It is not fixed; I encountered this problem again. Additionally, when I try to play a video on the iOS simulator, the app crashes. The main problem with the player is that the controller is not initializing properly. When I try to call initialize(), I get a "lateInitialization error."

@flowkscai
Copy link

It is not fixed; I encountered this problem again. Additionally, when I try to play a video on the iOS simulator, the app crashes. The main problem with the player is that the controller is not initializing properly. When I try to call initialize(), I get a "lateInitialization error."

Not related to this issue, you should open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants