Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 🐛 fix CEM loading in Storybook #427

Merged
merged 7 commits into from
Sep 25, 2023
Merged

Conversation

mariohamann
Copy link
Contributor

@mariohamann mariohamann commented Sep 22, 2023

Description:

PR notes: Please describe the changes in this PR.

This is a desperate draft to fix the CEM fetching/setting.

Definition of Reviewable:

PR notes: Irrelevant elements should be removed.

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked
  • PR is assigned to project board

@mariohamann mariohamann changed the title Mariohamann/issue421 fix: 🐛 fix CEM loading in Storybook Sep 25, 2023
@mariohamann
Copy link
Contributor Author

@solid-design-system/development Please review. :)

Copy link
Contributor

@yoezlem yoezlem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mariohamann mariohamann merged commit de7368f into main Sep 25, 2023
@mariohamann mariohamann deleted the mariohamann/issue421 branch September 25, 2023 09:47
karlbaumhauer pushed a commit that referenced this pull request Sep 25, 2023
# [@solid-design-system/components-v1.14.2](components/1.14.1...components/1.14.2) (2023-09-25)

### Bug Fixes

* 🐛 fix CEM loading in Storybook ([#427](#427)) ([de7368f](de7368f))
yoezlem pushed a commit that referenced this pull request Oct 9, 2023
yoezlem pushed a commit that referenced this pull request Oct 9, 2023
# [@solid-design-system/components-v1.14.2](components/1.14.1...components/1.14.2) (2023-09-25)

### Bug Fixes

* 🐛 fix CEM loading in Storybook ([#427](#427)) ([de7368f](de7368f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants