docs: 📚 Adding tokens and a11y to CONTRIBUTING.md #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarcMatthiae
requested review from
mariohamann,
karlbaumhauer,
azraefendic,
Vahid1919 and
yoezlem
karlbaumhauer
requested changes
Aug 10, 2023
Co-authored-by: Karl Baumhauer <[email protected]>
karlbaumhauer
approved these changes
Aug 10, 2023
azraefendic
reviewed
Aug 10, 2023
azraefendic
approved these changes
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
I slightly changed the "How we work" section. I actually wanted it to be all "We..."-sentences, but couldn´t find a way to formulate "Development closely works with Design." that way.
I added the usage of tokens and the optimization for accessibility to our dev guidelines, because I think they are important topics.
Definition of Reviewable: