Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve sd-headline a11y #1729

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

paulovareiro29
Copy link
Contributor

Description:

Closes #1504

This PR addresses:

  • Default story headline changed to h2.
  • Rephrase sd-headline stories description to explain why semantics and styles are disconnected
  • Add a template to show real life examples from disconnected headlines

Definition of Reviewable:

  • Documentation is created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

Copy link

changeset-bot bot commented Dec 12, 2024

🦋 Changeset detected

Latest commit: 265b14c

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

🚀 Storybook has been deployed for branch fix_improve-sd-headline-a11y

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 🏗 In progress
Development

Successfully merging this pull request may close these issues.

feat[dev]: ✨ implement A11y improvements to sd-headline
1 participant