Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update failing tests #1592

Merged
merged 2 commits into from
Oct 30, 2024
Merged

chore: update failing tests #1592

merged 2 commits into from
Oct 30, 2024

Conversation

smfonseca
Copy link
Contributor

Description:

This PR address two failing tests in the audio component

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

Copy link

github-actions bot commented Oct 25, 2024

🚀 Storybook has been deployed for branch fix_audio-tests

Vahid1919
Vahid1919 previously approved these changes Oct 28, 2024
@Vahid1919 Vahid1919 removed their assignment Oct 28, 2024
Copy link
Contributor

@mariohamann mariohamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to avoid external files as we this could lead to CDN issues (we already had that.) Isn't there a local way? I would even prefer base64. :D

@mariohamann mariohamann changed the title fix: update failing tests chore: update failing tests Oct 29, 2024
@mariohamann
Copy link
Contributor

Changed title, as no version bump needed.

@smfonseca
Copy link
Contributor Author

smfonseca commented Oct 29, 2024

We try to avoid external files as we this could lead to CDN issues (we already had that.) Isn't there a local way? I would even prefer base64. :D

I've added the audio as base64. We also need to update the sd-video tests since it's using an external source. Created a ticket for that.

Copy link
Contributor

@mariohamann mariohamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So beautiful ugly. :D

@smfonseca smfonseca merged commit d27309b into main Oct 30, 2024
12 of 13 checks passed
@smfonseca smfonseca deleted the fix/audio-tests branch October 30, 2024 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants