-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update failing tests #1592
Conversation
🚀 Storybook has been deployed for branch |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We try to avoid external files as we this could lead to CDN issues (we already had that.) Isn't there a local way? I would even prefer base64. :D
Changed title, as no version bump needed. |
I've added the audio as base64. We also need to update the sd-video tests since it's using an external source. Created a ticket for that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So beautiful ugly. :D
Description:
This PR address two failing tests in the audio component
Definition of Reviewable: