-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add disclaimer to address Storybook bug (wrong type in sd-carousel variant) #1551
base: main
Are you sure you want to change the base?
Conversation
This might be resolved, when we update and Storybook, move over to the current version of cc @smfonseca |
@mariohamann @karlbaumhauer |
@Vahid1919 |
Maybe we just wait with what @smfonseca comes up with, when the docs PR is ready, as he will have to update quite some dependencies already. Let's maybe move this to draft until that? |
fine for me. |
Description:
This bug arises due to Storybook interpreting the option name "number" as a type, even though we manually describe the type as a String. Changing the name resolves this issue, but making a breaking change for a Storybook issue is not viable.
Since this is not related to the component, I added a disclaimer to inform users of this issue. Closes #1249
Definition of Reviewable: