Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: #1193 correct clear button color in sd-icon and sd-select #1217

Merged
merged 3 commits into from
Jul 30, 2024
Merged

fix: #1193 correct clear button color in sd-icon and sd-select #1217

merged 3 commits into from
Jul 30, 2024

Conversation

auroraVasconcelos
Copy link
Contributor

@auroraVasconcelos auroraVasconcelos commented Jul 24, 2024 •
edited
Loading

Description:

Change "clear button' color in sd-input and sd-select from neutral-500 to neutral-800.
Change "valid input" text color from green to default text color for accessibility.

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@mariohamann mariohamann changed the title fix: #1193 correct clear button color in form fields fix: #1193 correct clear button color in sd-button and sd-select Jul 24, 2024
mariohamann
mariohamann approved these changes Jul 24, 2024
View reviewed changes
Copy link
Contributor

@mariohamann mariohamann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the title a bit to make it more explicit

@mariohamann mariohamann removed their assignment Jul 24, 2024
@MartaPintoTeixeira
Copy link
Contributor

Hey @auroraVasconcelos just left some comments on the UI Review.

@auroraVasconcelos auroraVasconcelos changed the title fix: #1193 correct clear button color in sd-button and sd-select fix: #1193 correct clear button color in sd-icon and sd-select Jul 26, 2024
@yoezlem yoezlem assigned coraliefeil and unassigned smfonseca Jul 26, 2024
@Vahid1919 Vahid1919 removed their assignment Jul 29, 2024
@coraliefeil coraliefeil removed their assignment Jul 30, 2024
@auroraVasconcelos auroraVasconcelos merged commit 0fa1fd2 into main Jul 30, 2024
10 of 12 checks passed
@auroraVasconcelos auroraVasconcelos deleted the fix/1193-correct-clear-button-color-in-form-fields branch July 30, 2024 15:14
karlbaumhauer pushed a commit that referenced this pull request Jul 30, 2024
@semantic-release-bot
chore(release/components): 3.10.2 [skip actions]
c3ef257 
# [@solid-design-system/components-v3.10.2](components/3.10.1...components/3.10.2) (2024-07-30)

### Bug Fixes

* [#1193](#1193) correct clear button color in sd-icon and sd-select ([#1217](#1217)) ([0fa1fd2](0fa1fd2))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yoezlem yoezlem yoezlem approved these changes

@Vahid1919 Vahid1919 Vahid1919 approved these changes

@smfonseca smfonseca smfonseca approved these changes

@mariohamann mariohamann mariohamann approved these changes

Assignees

@auroraVasconcelos auroraVasconcelos

Labels
None yet
Projects
Solid Design System Project Board
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@auroraVasconcelos @MartaPintoTeixeira @mariohamann @smfonseca @Vahid1919 @yoezlem @coraliefeil @van-nguyen-ht