Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: ✨ add sd-flipcard #1121

Merged
merged 40 commits into from
Jul 1, 2024
Merged

feat: ✨ add sd-flipcard #1121

merged 40 commits into from
Jul 1, 2024

Conversation

Vahid1919
Copy link
Contributor

@Vahid1919 Vahid1919 commented May 30, 2024 •
edited
Loading

Description:

Added sd-flipcard implementation .Closes #1012.

Definition of Reviewable:

  • Documentation is created/updated
  • Migration Guide is created/updated
  • E2E tests (features, a11y, bug fixes) are created/updated
  • Stories (features, a11y) are created/updated
  • relevant tickets are linked

@Vahid1919 Vahid1919 requested review from a team May 30, 2024 12:31
@Vahid1919 Vahid1919 self-assigned this May 30, 2024
@Vahid1919 Vahid1919 linked an issue May 30, 2024 that may be closed by this pull request
feat[dev]: ✨ implement sd-flipcard component #1012
Closed
33 tasks
karlbaumhauer
karlbaumhauer requested changes May 31, 2024
View reviewed changes
packages/components/src/components/flipcard/flipcard.ts Show resolved Hide resolved
packages/components/src/components/flipcard/flipcard.ts Outdated Show resolved Hide resolved
packages/components/src/components/flipcard/flipcard.ts Show resolved Hide resolved
packages/components/src/components/flipcard/flipcard.stories.ts Show resolved Hide resolved
packages/components/src/components/flipcard/flipcard.stories.ts Outdated Show resolved Hide resolved
packages/components/src/components/flipcard/flipcard.stories.ts Show resolved Hide resolved
packages/components/src/components/flipcard/flipcard.stories.ts Show resolved Hide resolved
packages/components/src/components/flipcard/flipcard.stories.ts Show resolved Hide resolved
packages/components/src/components/flipcard/flipcard.stories.ts Show resolved Hide resolved
packages/components/src/components/flipcard/flipcard.test.ts Outdated Show resolved Hide resolved
@karlbaumhauer karlbaumhauer removed their assignment May 31, 2024
@mariohamann
Copy link
Contributor

@Vahid1919 @coraliefeil @yoezlem So here's my proposal:

  1. Let's remove the aspect-ratio, but instead set aspect-ratio: 3 / 4 on :host, so we have a nice default. From that on let's show a story, that it's overridable with e. g. <sd-flipcard style="aspect-ratio: 16 / 9">.
  2. Let's introduce empty for front and back as default – which has no padding and anything. This makes it possible to use the flipcard with whatever needed. We leave the other options as they are, so that CMS can easily just pick them as they need.

van-nguyen-ht
van-nguyen-ht approved these changes Jun 17, 2024
View reviewed changes
Copy link
Contributor

@van-nguyen-ht van-nguyen-ht left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked the link and everything is aligned with design now.

@Vahid1919 Vahid1919 requested a review from smfonseca June 18, 2024 12:43
@Vahid1919 Vahid1919 mentioned this pull request Jun 25, 2024
Open
8 tasks
@Vahid1919 Vahid1919 merged commit ffd126f into main Jul 1, 2024
10 of 12 checks passed
@Vahid1919 Vahid1919 deleted the feat/flipcard branch July 1, 2024 08:02
karlbaumhauer pushed a commit that referenced this pull request Jul 1, 2024
@semantic-release-bot
chore(release/components): 3.8.0 [skip actions]
5ad480d 
# [@solid-design-system/components-v3.8.0](components/3.7.3...components/3.8.0) (2024-07-01)

### Features

* ✨ add sd-flipcard ([#1121](#1121)) ([ffd126f](ffd126f))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@karlbaumhauer karlbaumhauer karlbaumhauer approved these changes

@van-nguyen-ht van-nguyen-ht van-nguyen-ht approved these changes

@smfonseca smfonseca smfonseca approved these changes

@mariohamann mariohamann mariohamann approved these changes

Assignees

@azraefendic azraefendic

@mariohamann mariohamann

@smfonseca smfonseca

@Vahid1919 Vahid1919

@yoezlem yoezlem

Labels
None yet
Projects
Solid Design System Project Board
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat[dev]: ✨ implement sd-flipcard component
9 participants
@Vahid1919 @mariohamann @smfonseca @karlbaumhauer @van-nguyen-ht @azraefendic @coraliefeil @yoezlem @EllaELSA