Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: 🐛 prevent rewrite of inset property when border variant was selected in sd-teaser #362

Closed
mariohamann opened this issue Aug 31, 2023 · 0 comments · Fixed by #422
Closed

fix: 🐛 prevent rewrite of inset property when border variant was selected in sd-teaser #362

mariohamann opened this issue Aug 31, 2023 · 0 comments · Fixed by #422
Assignees
@azraefendic
Milestone
1st Solid Release

Comments

@mariohamann
Copy link
Contributor

mariohamann commented Aug 31, 2023 •
edited
Loading

As we realized in the daily today, there is a bug in the sd-teaser component:

solid/packages/components/src/components/teaser/teaser.ts

Line 82 in 7887ebd

this.inset = true;

Currently the property inset is rewritten. If you change to another variant, it's still inset, even if you didn't change it.

Instead I would propose to write something like:
const inset = this.variant === 'white border-neutral-300' || this.inset

And refer to this const from now on, instead to this.variant.

Please write a test after it is fixed that sets a fixture <sd-teaser variant="white border-neutral-300">...</sd-teaser> changes the variant and checks if inset is still false.

@azraefendic
@mariohamann mariohamann changed the title fix: 🐛 iprevent rewrite of inset property when border variant was selected in sd-teaser fix: 🐛 prevent rewrite of inset property when border variant was selected in sd-teaser Sep 1, 2023
@karlbaumhauer karlbaumhauer added this to the 1st Solid Release milestone Sep 6, 2023
@azraefendic azraefendic moved this from 🔖 Ready to 🏗 In progress in Solid Design System Project Board Sep 21, 2023
@azraefendic azraefendic mentioned this issue Sep 21, 2023
Merged
2 tasks
@azraefendic azraefendic moved this from 🏗 In progress to 👀 In review in Solid Design System Project Board Sep 21, 2023
azraefendic added a commit that referenced this issue Sep 22, 2023
@azraefendic
fix: 🐛 prevent rewrite of inset property when border variant was sele…
ada5be7 
…cted in sd-teaser (#422)

## Description:
Fixed a bug in sd-teaser to prevent rewrite of inset property when
changing variants and added a corresponding test for it. Closes #362

## Definition of Reviewable:
*PR notes: Irrelevant elements should be removed.*
- [x] relevant tickets are linked
- [x] PR is assigned to project board
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Solid Design System Project Board Sep 22, 2023
karlbaumhauer pushed a commit that referenced this issue Sep 22, 2023
@semantic-release-bot
chore(release/components): 1.14.1 [skip actions]
ead1954 
# [@solid-design-system/components-v1.14.1](components/1.14.0...components/1.14.1) (2023-09-22)

### Bug Fixes

* 🐛 prevent rewrite of inset property when border variant was selected in sd-teaser ([#422](#422)) ([ada5be7](ada5be7)), closes [#362](#362)
yoezlem pushed a commit that referenced this issue Oct 9, 2023
@azraefendic @yoezlem
fix: 🐛 prevent rewrite of inset property when border variant was sele…
bfa8efa 
…cted in sd-teaser (#422)

## Description:
Fixed a bug in sd-teaser to prevent rewrite of inset property when
changing variants and added a corresponding test for it. Closes #362

## Definition of Reviewable:
*PR notes: Irrelevant elements should be removed.*
- [x] relevant tickets are linked
- [x] PR is assigned to project board
yoezlem pushed a commit that referenced this issue Oct 9, 2023
@semantic-release-bot @yoezlem
chore(release/components): 1.14.1 [skip actions]
22ce2b4 
# [@solid-design-system/components-v1.14.1](components/1.14.0...components/1.14.1) (2023-09-22)

### Bug Fixes

* 🐛 prevent rewrite of inset property when border variant was selected in sd-teaser ([#422](#422)) ([ada5be7](ada5be7)), closes [#362](#362)
yoezlem pushed a commit that referenced this issue Oct 9, 2023
@semantic-release-bot @yoezlem
chore(release/components): 1.14.1 [skip actions]
1571b1c 
* 🐛 prevent rewrite of inset property when border variant was selected in sd-teaser ([#422](#422)) ([ada5be7](ada5be7)), closes [#362](#362)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@azraefendic azraefendic

Labels
None yet
Projects
Solid Design System Project Board
Archived in project
Milestone
1st Solid Release
3 participants
@azraefendic @mariohamann @karlbaumhauer