Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test WAC-Allow header #8

Merged
merged 5 commits into from
Nov 26, 2020
Merged

Test WAC-Allow header #8

merged 5 commits into from
Nov 26, 2020

Conversation

michielbdejong
Copy link
Collaborator

No description provided.

@michielbdejong
Copy link
Collaborator Author

+import fetch from 'node-fetch';

@michielbdejong
Copy link
Collaborator Author

This does pass:

it(`Shows the correct WAC-Allow header on Alice's public folder`, async () => {
    const result = await solidLogicBob.fetch(`https://server/public/`);
    expect(result.headers.get('WAC-Allow')).toEqual('user="read",public="read"');
});

@edwardsph
Copy link
Contributor

edwardsph commented Nov 23, 2020

I'm not sure I got the process right for offering a PR on top of a request to review a PR - please let me know if there was a better way to do this.

Fix WAC-allow tests accounting for a user inheriting public permissions
@michielbdejong
Copy link
Collaborator Author

Merged your PR into mine, if you approve this one, then i will merge it.

Copy link
Contributor

@edwardsph edwardsph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michielbdejong michielbdejong merged commit b482b25 into master Nov 26, 2020
@edwardsph edwardsph mentioned this pull request Nov 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants