NH-76996 - Disabled platform events log processing #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheempz
reviewed
Jun 4, 2024
| } else { | ||
| r.logger.Error("error parsing time", zap.Error(err)) | ||
| return plog.Logs{}, err | ||
| } | ||
| if el.Type == string(telemetryapi.Function) || el.Type == string(telemetryapi.Extension) { |
There was a problem hiding this comment.
I thought we agreed not to forward Extension events as logs?
There was a problem hiding this comment.
Yes, the logic is the same. The decision now is made from the subscription type.
There was a problem hiding this comment.
I see. Can we just not subscribe to anything other than Function events for this round to minimize overhead?
|
Disabled log forwarding by commenting out logs pipeline in config.yaml |
jerrytfleung
added a commit
that referenced
this pull request
Jul 18, 2024
* Disable platform events log stringify
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabled platform events log processing
https://swicloud.atlassian.net/browse/NH-76996