-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-82144 and NH-81061: multi-runtime lambda layer #131
Conversation
Quick question: not seeing the APM library version in the layer name, i.e. there's a trailing
I was expecting
|
Yes, it will be |
@xuan-cao-swi I'm wondering about the reason for a slightly different approach here (using SAM container images for ruby) vs open-telemetry/opentelemetry-lambda#1376. It does seem more convenient to use the prefab SAM container, and indeed we don't need to keep our layer build the same as upstream since we have vendor-specific concerns. Mainly curious what was the rationale and your intent going forward. Oh maybe for our layer you used this approach? https://docs.aws.amazon.com/lambda/latest/dg/ruby-package.html#ruby-package-native |
It's mainly because of different version of glibc (ubuntu:latest vs amazonlinux2) for compiling the liboboe. Since all aws ruby lambda runtime start with amazonlinux2 or amazonlinux2023, so when we build our apm-ruby layer, the glibc version have to be aligned with what amazonlinux glibc version. I think it's easier to use sam image so that I am sure the os has the correct glibc version As upstream (standalone) opentelemetry-sdk doesn't need compile anything with glibc (e.g. liboboe), it doesn't matter which image to use for build. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Change the build process using docker image for multi-runtime layer.
Reserved the sam build material for extra use (mainly debugging)
Test (if applicable)
Action run: https://github.com/solarwinds/apm-ruby/actions/runs/9485541864
x86_64 ➕ arm64