NH-29380 Remove unused enable_sanitize_sql config #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swi-jared
previously approved these changes
Jun 8, 2023
|
Oh man peanut brain move with the merge conflicts today 🙈 |
swi-jared
approved these changes
Jun 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
EDIT: 2 PRs in one now yay
Similar to #163
This removes
enable_sanitize_sqlfrom APM Python config. It is not used for anything at the moment. Sanitization of sql statements used for any span attributes is partially handled by the Python query libraries at the moment (prepared statements). Further sanitization (e.g. hardcoded statements) should be handled upstream by the Otel instrumentation libraries and an Otel configuration. Issues are out there for this already:db.statementopen-telemetry/opentelemetry-python-contrib#1376Similar to #163 and #164
This removes is_grpc_clean_hack_enabled from APM Python config. It is not currently used and I don't think it's needed since liboboe 12.0.0 (https://swicloud.atlassian.net/browse/NH-28555) but please let me know if I'm wrong! The value is not used to config Reporter nor anything else. This value was copied from AO which I think used it as a hidden option to re-activate a hack (https://github.com/librato/python-appoptics/pull/254).