NH-91598: set otlp metrics exporter configurations #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lean up ci runner disk.
xuan-cao-swi
approved these changes
Sep 27, 2024
| String serviceKey = (String) container.get(ConfigProperty.AGENT_SERVICE_KEY); | ||
| String apiKey = ServiceKeyUtils.getApiKey(serviceKey); | ||
|
|
||
| String dataCell = "na-01"; |
There was a problem hiding this comment.
nit: would it be possible to have these static variables and the collector endpoint parsing logic in a shared location for logs and traces exporter?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tl;dr: add
SW_APM_EXPORT_METRICS_ENABLEDconfiguration optionContext:
This PR adds configuring of OTel metrics export when the new configuration option is set via environment or the config file. Additional changes where made in the CI config to fix a bug and to clean disk space. The disk clean up was added because of warning from Github action about low disk space that was causing some jobs to fail as a result.
We also refactored the configuration machinery to use signal specific configuration option for the protocol to avoid inadvertently wiring up of none needed signal export machinery that always fails. Additional unit and integration tests were added
Test Plan:
Test services data 0, 1 and 2