CUST-110209: remove joboe logging from SDK #256
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…UL to avoid runtime failure when agent is not attached.
tammy-baylis-swi
approved these changes
Aug 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
joboe:loggingfrom the SDK. It was added initially to fixjava.lang.NoClassDefFoundErrorthat occur due to relocation ofJUL(java.util.logger). That didn't fix problem, it replaced it with a new one. Now, we've reverted the change and remove the relocation becauseJULis a JVM API and it's okay to remove the relocation.JULhas been part of the JVM sincev1.4according to the docstring.Test Plan:
Test services data 0, 1 and 2