Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-37575 Move benchmark job to push workflow #240

Merged
merged 5 commits into from
Jul 11, 2024
Merged

Conversation

cleverchuk
Copy link
Contributor

@cleverchuk cleverchuk commented Jul 8, 2024

Tl;dr: Fix benchmark job

Context:

This PR fixes the benchmark job by removing container liveness check because it isn't working and moves it to the Push work flow so it runs on every push. Also adds some formatting change to keep it interesting 😁

Supersedes #239

Test Plan:
Test services 0, 1 and 2

@cleverchuk cleverchuk requested a review from a team as a code owner July 8, 2024 17:36
@cleverchuk cleverchuk changed the title Cc/nh 37575 refactor NH-37575 refactor jobs and tests Jul 8, 2024
@cleverchuk cleverchuk changed the title NH-37575 refactor jobs and tests NH-37575 Move benchmark job to push workflow Jul 8, 2024
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Added a comment about removing AO from the mix, and minor how about updating the summary wording to something like:

 Run at Mon Jul 08 19:09:08 UTC 2024
 release : compares no agent, latest Otel standard, and latest SWO agents
 5 users, 5000 iterations
----------------------------------------------------------
| Agent              |            OTel   |              SWO |             none |
| ------             |            ------ |           ------ |           ------ |

@@ -22,7 +22,8 @@ public class Agent {
new Agent("latest", "latest mainstream release", OTEL_LATEST);
public static final Agent LATEST_SNAPSHOT =
new Agent("snapshot", "latest available snapshot version from main");
public static final Agent NH_LATEST_RELEASE = new Agent(LatestSolarwindsAgentResolver.useAOAgent ? "AO" : "NH", "latest Solarwinds agent");
public static final Agent NH_LATEST_RELEASE =
new Agent(LatestSolarwindsAgentResolver.useAOAgent ? "AO" : "NH", "latest Solarwinds agent");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we're far enough along with SWO Java at this point that the AO option can be removed in this benchmark, or replace it with SWO GA (to compare current build with released one).

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@cleverchuk cleverchuk force-pushed the cc/NH-37575-refactor branch 3 times, most recently from 0a04974 to 34b74fa Compare July 10, 2024 19:54
@cleverchuk cleverchuk requested a review from cheempz July 10, 2024 20:16
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @cleverchuk for enabling CodeQL too! Good to see its scan findings. A couple nitpicky comments.


# Autobuild fails so use custom build steps
- name: Set up JDK 17
uses: actions/setup-java@v3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems GHA is warning about this using deprecated Node.js version, use v4 instead?

.withEnv("APPOPTICS_TRUSTEDPATH", "/test-server-grpc.crt")
.withEnv("APPOPTICS_DEBUG_LEVEL", "info")
.withEnv("APPOPTICS_COLLECTOR", "AOCollector:12223")
.withEnv("APPOPTICS_TRUSTEDPATH", "/test-server-grpc.crt")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor, can remove?

@cleverchuk cleverchuk force-pushed the cc/NH-37575-refactor branch from 34b74fa to 5b758ac Compare July 11, 2024 12:23
@cleverchuk cleverchuk requested a review from cheempz July 11, 2024 12:23
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 thanks @cleverchuk!

@cleverchuk cleverchuk merged commit b84c495 into main Jul 11, 2024
11 checks passed
@cleverchuk cleverchuk deleted the cc/NH-37575-refactor branch July 11, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants