Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-2314: W3C trace context propagation #13

Merged
merged 22 commits into from
Nov 3, 2021
Merged

Conversation

ghost
Copy link
Contributor

@ghost ghost commented Sep 28, 2021

This PR fully replaces the AppOptics X-Trace ID with W3C trace context in context propagations either within a process (parent-child spans) or cross process boundaries (remote service call)

See also https://swicloud.atlassian.net/wiki/spaces/NIT/pages/2325479753/W3C+trace+context#Deprecate-x-trace-Request-Header

Repository owner requested a review from d87f71d598f4db10bfa0f4b71d0afbe3171_swi October 28, 2021 17:18
@ghost
Copy link
Contributor Author

ghost commented Oct 28, 2021

@prettycoder Maia as you are very knowledgable to the W3C trace context could you take a look when you get a chance? Thanks. :)

Repository owner requested review from Lin-Lin_swi and tingfung-leung_swi October 28, 2021 17:21
@ghost
Copy link
Contributor Author

ghost commented Oct 28, 2021

Added @jerrytfleung and @cheempz too please leave some comments when you have time to look at it, no hurry though 😄

Copy link
Mannequin

@d87f71d598f4db10bfa0f4b71d0afbe3171_swi d87f71d598f4db10bfa0f4b71d0afbe3171_swi mannequin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

some shortcuts could be taken in the processing for tracestate if performance requires optimization

NH-2651: Update appoptics dependencies
Repository owner merged commit 2e44b5b into master Nov 3, 2021
Repository owner deleted the NH-2314-w3c-trace-context branch March 16, 2022 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants