Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony EventDispatcher 7 #1135

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

thomascorthals
Copy link
Member

@thomascorthals thomascorthals commented Oct 17, 2024

There's nothing backward incompatible for us in version 7. I've been running it like that for a while in a production environment without issues and the integration tests all pass. So we shouldn't give the impression that Solarium would only work with an older version.

Copy link

codecov bot commented Oct 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.74%. Comparing base (9cdf3dd) to head (55f285b).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1135      +/-   ##
==========================================
- Coverage   97.75%   97.74%   -0.02%     
==========================================
  Files         400      400              
  Lines       10524    10455      -69     
==========================================
- Hits        10288    10219      -69     
  Misses        236      236              
Flag Coverage Δ
unittests 97.74% <ø> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant