Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

program: patch a few small conformance mismatches #48

Merged
merged 5 commits into from
Nov 20, 2024
Merged

Conversation

buffalojoec
Copy link
Contributor

Just a few more small conformance mismatches that came from working with Firedancer's tooling.

  1. Reordering lamport deduction and account realloc (on CloseLookupTable): This ordering now matches the builtin exactly.
  2. Add readonly check for lookup table on CloseLookupTable: This throws a ReadonlyDataModified error at the proper callsite.
  3. Add readonly lamport check for recipient on CloseLookupTable: This one is a little pedantic, but again, it provides exact backwards compatibility with error codes and throw/call sites.
  4. Map sol_get_sysvar to UnsupportedSysvar: When the slot hashes data is malformed, the API for SlotHashesSysvar throws InvalidAccountData (which I think does make more sense), however the sysvar cache will throw UnsupportedSysvar for the builtin. Updates to align the codes.

Copy link
Contributor

@joncinque joncinque left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@buffalojoec buffalojoec merged commit 779454e into main Nov 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants