Ensure accounts are always derived for privileged apps #370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdlaver
commented
Nov 22, 2024
| @@ -162,23 +162,18 @@ class SeedRepository @Inject constructor( | |||
| check(!seeds.value.containsKey(nextSeedId)) { "Seed repository already contains an entry for seed $nextSeedId" } | |||
| newSeedRecordBuilder.seedId = nextSeedId | |||
| id = nextSeedId | |||
| val changeNotification = ChangeNotification( | |||
There was a problem hiding this comment.
None of the changes in this file are strictly necessary, but it cuts down on unnecessary change notifications when nothing actually changed, which improves performance of apps that make use of content notifications.
sdlaver
commented
Nov 22, 2024
| // Ensure that the seed vault contains appropriate known accounts for this authorization purpose | ||
| val seed = seedRepository.seeds.value[seedId]!! | ||
| PrepopulateKnownAccountsUseCase(seedRepository).populateKnownAccounts(seed, authorize.purpose) | ||
| // Pre-populate known accounts for all purposes |
There was a problem hiding this comment.
This is the fix for the root cause of known accounts not being derived.
sdlaver
commented
Nov 22, 2024
| @@ -44,6 +45,14 @@ class MainViewModel( | |||
| viewModelScope.launch { | |||
| observeSeedVaultContentChanges() | |||
| refreshUiState() | |||
|
|
|||
| // Privileged wallets do not manually authorize individual seeds, so check on startup | |||
There was a problem hiding this comment.
This fixes privileged wallets not having any accounts marked as user accounts, and thus an incomplete FakeWallet UI
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.