Fixing detection of priviledged protection level of SEED_VAULT_IMPL permission #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sdlaver
approved these changes
Feb 14, 2023
sdlaver
reviewed
Feb 14, 2023
| @@ -49,7 +51,7 @@ public static boolean isAvailable(@NonNull Context context, boolean allowSimulat | |||
|
|
|||
| for (PermissionInfo permission : pi.permissions) { | |||
| if (WalletContractV1.PERMISSION_SEED_VAULT_IMPL.equals(permission.name) && | |||
| ((permission.flags & PermissionInfo.PROTECTION_FLAG_PRIVILEGED) != 0)) { | |||
| ((permission.getProtectionFlags() & PROTECTION_FLAG_PRIVILEGED) != 0)) { | |||
There was a problem hiding this comment.
There was a problem hiding this comment.
/home/runner/work/seed-vault-sdk/seed-vault-sdk/seedvault/src/main/java/com/solanamobile/seedvault/SeedVault.java:54: Error: Call requires API level 28 (current min is 23): android.content.pm.PermissionInfo#getProtectionFlags [NewApi]
((permission.getProtectionFlags() & PROTECTION_FLAG_PRIVILEGED) != 0)) {
~~~~~~~~~~~~~~~~~~
There was a problem hiding this comment.
Can probably just use the protectionLevel field directly: https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/content/pm/PermissionInfo.java;l=361
J909
force-pushed
the
fix-impl-detection
branch
from
f427b89 to
c784011
Compare
sdlaver
approved these changes
Feb 14, 2023
J909
force-pushed
the
fix-impl-detection
branch
from
63e1113 to
4700cce
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the detection of the privileged protection level of
com.solanamobile.seedvault.SEED_VAULT_IMPLalways fails.This change queries the protection level of this permission to detect its implementation on the system image.
Fixes #115