Wallet Standard Remote Wallet #957
Conversation
There was a problem hiding this comment.
Should we wait with merging this until we build WebBluetooth connections end-to-end?
| #disconnect: StandardDisconnectMethod = async () => { | ||
| // TODO: figure out why this call throws "TypeError: _a.terminateSession is not a function" | ||
| // even though the session termination is actually executed (websocket closes). | ||
| try { this.#wallet?.terminateSession(); } catch (e) {} |
There was a problem hiding this comment.
Could stem from the remote proxy implementation of the TerminateSessionAPI interface assigning an 'any' property instead of a function?
There was a problem hiding this comment.
hmm good thought, let me investigate 🦺
There was a problem hiding this comment.
fixed!
I still don't love this solution of using the wallet proxy request handler to handle what is not an MWA RPC request (terminateSession). But for now I think its the best way to add this functionality - I am thinking about a big refactor to the js impl to clean this up. the terminate session API is not exposed directly to consumers so it will be safe to refactor the implementation later on.
| try { | ||
| const cachedAuthorizationResult = await this.#authorizationResultCache.get(); | ||
| if (cachedAuthorizationResult) { | ||
| // TODO: Evaluate whether there's any threat to not `awaiting` this expression |
There was a problem hiding this comment.
Is the assumption that pubkey / cachedAuthorizationResult.accounts shouldn't have changed at this point?
There was a problem hiding this comment.
I think so, that is my understanding. this comment + logic are a hold over from the original implementation. So I left as much of the original logic as possible - for now. I basically wanted to re-wrap everything as-is into a wallet-standard lib. Once we know that is working I plan to refactor some stuff and clean up TODOs like this,
Funkatronics
changed the title
No description provided.