Maintain sysvar balances for consistent market cap. #9936
Conversation
| @@ -563,16 +563,20 @@ impl Bank { | |||
| self.store_account(pubkey, &new_account); | |||
| } | |||
|
|
|||
| fn inherit_sysvar_account_balance(&self, old_account: &Option<Account>) -> u64 { | |||
There was a problem hiding this comment.
Why not Self::? hint: for gating logic of backport prs: self.epoch().
| fn fmt(&self, f: &mut Formatter) -> Result { | ||
| write!( | ||
| f, | ||
| "{}.{:09} SOL", |
There was a problem hiding this comment.
I'm planning to promote this to the Display across the whole cli. But, that change will be invasive; let's minimize for now.
There was a problem hiding this comment.
Also, this pr absolutely needs this precision over f64 because capitalization tends to be well larger than the significant digits of f64.
| computed_capitalization | ||
| ); | ||
| } | ||
| println!("Capitalization: {}", Sol(bank.capitalization())); |
There was a problem hiding this comment.
@danpaul000 FYI: I've created the rust version of capitalization bash script, which you created in that past iirc. :)
$ RUST_LOG=solana=error solana-ledger-tool --ledger config/ledger/ capitalization
Capitalization: 999999999.998820000 SOL
| } | ||
| } | ||
|
|
||
| let computed_capitalization: u64 = bank |
| .get_program_accounts(None) | ||
| .into_iter() | ||
| .filter_map(|(_pubkey, account)| { | ||
| if account.lamports == u64::max_value() { |
There was a problem hiding this comment.
this is like this handling (at #9869) CC: @CriesofCarrots:
- Filter out Storage program
RewardsPools that get initialized with u64::MAX lamports
| } | ||
|
|
||
| let is_specially_retained = | ||
| solana_sdk::native_loader::check_id(&account.owner) |
There was a problem hiding this comment.
@jackcmay I'm not that familiar with loaders... Well, loaders can have similar problem as this pr? What happens to the balance if one of loaders is updated? (or not updated ever, first of all?)
There was a problem hiding this comment.
Well, it seems that I can't change of account.lamports first of all:
$ solana --url http://localhost:8899 pay -v Stake11111111111111111111111111111111111111 0.82643
RPC URL: http://localhost:8899
Default Signer Path: /home/ryoqun/.config/solana/id.json
Error: TransactionError::InstructionError(0, ExecutableLamportChange)
There was a problem hiding this comment.
Once marked executable you can't change its lamports
There was a problem hiding this comment.
And, iirc the executable bit can't be off after that, too? :)
Codecov Report
@@ Coverage Diff @@
## master #9936 +/- ##
======================================
Coverage 80.4% 80.4%
======================================
Files 283 283
Lines 65917 65951 +34
======================================
+ Hits 53027 53073 +46
+ Misses 12890 12878 -12 |
|
Well, this was dos, fixed now on the mainnet-beta: https://github.com/solana-labs/solana/pull/9937/files#r424512737 |
problem
sysvar account's balance is forced to overwrite to the fixed 1-lamport for each update even after someone transfers some lamports to it (btw, this effectively burns the lamports and so it must be mistake, anyway).
That creates discrepancy between
bank.capitalizationand the actual sum of all alive account balances.solution
Correctly, inherit the deposited balance when updating sysvars.
Also, add subcommand
solana-ledger-tool capitalizationwhich shows the capitalization after verifying there is no discrepancy.