This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
v1.1: Include account.owner into account hash #9918
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
reviewed
May 7, 2020
Codecov Report
@@ Coverage Diff @@
## v1.1 #9918 +/- ##
=====================================
Coverage 80.7% 80.7%
=====================================
Files 282 282
Lines 64420 64436 +16
=====================================
+ Hits 51996 52027 +31
+ Misses 12424 12409 -15 |
mvines
approved these changes
May 7, 2020
|
@mvines Thanks for review! I'm testing this locally now with tds snapshots... |
mvines
changed the title
|
@ryoqun - is your testing complete? Ok to merge? |
ryoqun
commented
May 22, 2020
| @@ -1296,13 +1305,20 @@ impl AccountsDB { | |||
| hasher.result() | |||
| } | |||
|
|
|||
| pub fn include_owner_in_hash(slot: Slot) -> bool { | |||
| // Account hashing updated to include owner activates at this slot on the testnet | |||
| slot >= 14_000_000 | |||
There was a problem hiding this comment.
Well, my bad. This will not quite work for devnet............ devnet is still at around slot 5_356_748.
Gating logic is hard. Sorry about that. The excuse is that I only cared tds and mainnet-beta; that's already complicated enough to do flawless rolling update; not at all for devnet at the time of this pr....
This causes bankhash incompatibility between v1.1 branch and master branch for devnet: #10163 (comment)
FYI: @CriesofCarrots
mvines
pushed a commit
to mvines/solana
that referenced
this pull request
May 25, 2020
solana-grimes
pushed a commit
that referenced
this pull request
May 25, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
manual backport of #9917 with gating logic for the v1.x / tds
fixes #9916