Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cargo check all targets #9718

Merged
merged 4 commits into from
Apr 25, 2020
Merged

Cargo check all targets #9718

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0121435
Include top level Cargo.lock...
ryoqun Apr 25, 2020
73fab74
Add --all-targets
ryoqun Apr 25, 2020
39e49d8
Use nightly...
ryoqun Apr 25, 2020
375fad1
outdated Cargo.lock again...
ryoqun Apr 25, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
39 changes: 28 additions & 11 deletions Cargo.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion ci/test-checks.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ export RUSTFLAGS="-D warnings"
# Look for failed mergify.io backports
_ git show HEAD --check --oneline

if _ scripts/cargo-for-all-lock-files.sh check --locked; then
if _ scripts/cargo-for-all-lock-files.sh +"$rust_nightly" check --locked --all-targets; then
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+"$rust_nightly" needed for this: https://buildkite.com/solana-labs/solana/builds/23350#c4cb3312-b32d-42b1-bda2-1e2cdc091a4b/70-475

    Checking solana-ownable v1.2.0 (/solana/programs/ownable)
    Checking solana-btc-spv-program v1.2.0 (/solana/programs/btc_spv)
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> sdk/benches/slot_history.rs:1:1
  |
1 | #![feature(test)]
  | ^^^^^^^^^^^^^^^^^
 
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> sdk/benches/slot_hashes.rs:1:1
  |
1 | #![feature(test)]
  | ^^^^^^^^^^^^^^^^^
 
error[E0554]: `#![feature]` may not be used on the stable release channel
 --> sdk/benches/short_vec.rs:1:1
  |
1 | #![feature(test)]
  | ^^^^^^^^^^^^^^^^^
 
error: aborting due to previous error

true
else
check_status=$?
Expand Down
2 changes: 1 addition & 1 deletion scripts/cargo-for-all-lock-files.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ if [[ -n $escape_marker && ${#shifted_args[@]} -gt 0 ]]; then
done
shifted_args=()
else
files="$(git ls-files :**/Cargo.lock)"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

;)

... and we got 375fad1

files="$(git ls-files :**Cargo.lock)"
fi

for lock_file in $files; do
Expand Down