validator: Add support for log rotation, sending SIGUSR1 will cause the log file to be re-opened #9713
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9713 +/- ##
========================================
- Coverage 80.5% 80.4% -0.2%
========================================
Files 279 279
Lines 63939 63939
========================================
- Hits 51514 51441 -73
- Misses 12425 12498 +73 |
mvines
added a commit
that referenced
this pull request
Apr 24, 2020
… to be re-opened (#9713) (#9715) (cherry picked from commit 50f1ec0) Co-authored-by: Michael Vines <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Firehosing /var/log/syslog with validator logs isn't great, and neither is filling up the disk with a single log file. We really need proper log rotation. The existing logrotate daemon fits the bill perfectly, but deploying a logrotate solution requires cooperation from
solana-validatorto re-open its log file when signaled.