Cap repair requests timeout #958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sakridge
force-pushed
the
cap-repair-request-backoff
branch
from
52ff5a5 to
a6e96d0
Compare
sakridge
force-pushed
the
cap-repair-request-backoff
branch
from
a6e96d0 to
b4a47e6
Compare
|
How about they |
|
I'm not sure how it helps because then they have to do a bunch of extra work to catch up and then they are even further behind. |
|
This particular feature could run under the premise that a node is able to enter the network successfully. Falling behind might suggest a memory leak that causes the validator not to be able to process transactions as quickly as it did when it entered. Restarting might make it a useful miner again until the said leak forces it to restart once again. It's easy to imagine a profitable validator restarting daily. |
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
* Add extra check on instruction fuzz * Refactor division * Fix tests from fixed deposit math * Fixup comments and cleanup fuzz * Run fmt * Address review feedback * Fix JS test
brooksprumo
added a commit
to brooksprumo/solana
that referenced
this pull request
Apr 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When nodes get too far behind they can spend 3-4 seconds just sending 1 or 2 repair requests. These can get dropped or go to nodes which don't have the blob yet, so send repair requests at ~64 blobs received which may give them a better chance to catch up.