Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[don't merge] Bump libloading from 0.5.2 to 0.6.1 #9508

Closed
wants to merge 7 commits into from

Conversation

dependabot-preview[bot]
Copy link
Contributor

@dependabot-preview dependabot-preview bot commented Apr 15, 2020

This PR is currently the test subject for #9508

Bumps libloading from 0.5.2 to 0.6.1.

Commits
  • 3ded2f8 Release v0.6.1
  • 511668a Add support for the illumos triple
  • 9bcbc3c Avoid changing the error variant name for now - Should be done in the next br...
  • 9395c4d Change the comment as well into LoadLibraryExW
  • e4fa765 [Windows]: LoadLibraryExW - document the reserved parameter
  • 8bde6ba [Windows]: Allow LoadLibraryExW
  • 727e827 Fill in the date in the changelog
  • b784300 Fix deprecated mem::uninitialized.
  • c951db8 Modernize AtomicBool initializer in Windows code
  • 7398d96 Implement the Error type
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
  • @dependabot use these labels will set the current labels as the default for future PRs for this repo and language
  • @dependabot use these reviewers will set the current reviewers as the default for future PRs for this repo and language
  • @dependabot use these assignees will set the current assignees as the default for future PRs for this repo and language
  • @dependabot use this milestone will set the current milestone as the default for future PRs for this repo and language
  • @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in your Dependabot dashboard:

  • Update frequency (including time of day and day of week)
  • Pull request limits (per update run and/or open at any time)
  • Automerge options (never/patch/minor, and dev/runtime dependencies)
  • Out-of-range updates (receive only lockfile updates, if desired)
  • Security updates (receive only security updates, if desired)

@ryoqun ryoqun changed the title Bump libloading from 0.5.2 to 0.6.1 [don't merge] Bump libloading from 0.5.2 to 0.6.1 Apr 17, 2020
@ryoqun ryoqun force-pushed the dependabot/cargo/libloading-0.6.1 branch from 5bff7d9 to 9648ab4 Compare April 17, 2020 14:44
@ryoqun ryoqun force-pushed the dependabot/cargo/libloading-0.6.1 branch from 0360665 to f378294 Compare April 17, 2020 15:17
@@ -81,12 +81,12 @@ impl NativeLoader {
}

#[cfg(windows)]
fn library_open(path: &PathBuf) -> std::io::Result<Library> {
fn library_open(path: &PathBuf) -> Result<Library, libloading::Error> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jackcmay (Ignore bunch of other code in this pr); This file's 2 hunks (this and the next) is the only smart-contract-related code changes to bump libloading to follow upstream's new API. I believe this changes don't have problems. I'm asking you just in case. :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ryoqun Looks good to me!

@jackcmay jackcmay self-requested a review April 17, 2020 16:26
@codecov
Copy link

codecov bot commented Apr 17, 2020

Codecov Report

Merging #9508 into master will decrease coverage by 0.0%.
The diff coverage is 100.0%.

@@           Coverage Diff            @@
##           master   #9508     +/-   ##
========================================
- Coverage    80.8%   80.8%   -0.1%     
========================================
  Files         278     278             
  Lines       62908   62908             
========================================
- Hits        50838   50831      -7     
- Misses      12070   12077      +7     

@ryoqun ryoqun force-pushed the dependabot/cargo/libloading-0.6.1 branch from 25dbd00 to e37755a Compare April 20, 2020 10:52
@ryoqun
Copy link
Member

ryoqun commented Apr 21, 2020

@dependabot rebase

@dependabot-preview
Copy link
Contributor Author

Looks like this PR has been edited by someone other than Dependabot. That means Dependabot can't rebase it - sorry!

If you're happy for Dependabot to recreate it from scratch, overwriting any edits, you can request @dependabot recreate.

@ryoqun ryoqun closed this Apr 21, 2020
@dependabot-preview
Copy link
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot-preview dependabot-preview bot deleted the dependabot/cargo/libloading-0.6.1 branch April 21, 2020 02:57
@ryoqun
Copy link
Member

ryoqun commented Apr 21, 2020

All changes in this PR are merged by other prs: #9554, #9180, #9619 and #9615 (CC @jackcmay, thanks for helping!)

So, closing this. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants