Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reinstate commitment param on getSignatureStatuses to support old clients #9323

Conversation

CriesofCarrots
Copy link
Contributor

@CriesofCarrots CriesofCarrots commented Apr 6, 2020

Problem

Using an old client/cli with the new rpc results in commitment-related errors:

$ solana airdrop 10 --url http://devnet.solana.com

Requesting airdrop of 10 SOL from 35.233.193.70:9900
Error: rpc request error: RPC Error response: {"code":-32602,"message":"Invalid params: missing field searchTransactionHistory."}

Summary of Changes

  • Reinstate commitment to support old clients, mark as deprecated to be removed on next client release

@CriesofCarrots CriesofCarrots changed the title Reinstate commitment param on getSignatureStatus to support old clients Reinstate commitment param on getSignatureStatuses to support old clients Apr 6, 2020
Copy link
Member

@mvines mvines left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about we just land this on 1.1 and 1.0, not master. No need to remove the deprecated code then, it just disappears

@CriesofCarrots
Copy link
Contributor Author

How about we just land this on 1.1 and 1.0, not master. No need to remove the deprecated code then, it just disappears

Ah, good idea. Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants