Dynamically bind to available UDP ports in Fullnode #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvines
reviewed
Aug 9, 2018
src/crdt.rs
Outdated
| @@ -1353,6 +1354,55 @@ impl TestNode { | |||
| }, | |||
| } | |||
| } | |||
| pub fn new_with_external_ip(pubkey: Pubkey, ip: IpAddr) -> TestNode { | |||
| fn bind() -> (u16, UdpSocket) { | |||
| match udp_random_bind(8000, 10000, 5) { | |||
There was a problem hiding this comment.
Should we use 8001, or maybe 8100, instead of 8000? 8000 is hard coded in places like
Line 55 in bca2294
There was a problem hiding this comment.
I have changed it to 8100 for now. I think, going forward, only NCP port for leader needs to be hardcoded. If someday we add a DNS entry with SRV record, we can potentially remove that as well.
pgarg66
force-pushed
the
dynamic-ports
branch
2 times, most recently
from
4bdc510 to
6f13fa0
Compare
mvines
approved these changes
Aug 9, 2018
pgarg66
force-pushed
the
dynamic-ports
branch
2 times, most recently
from
19b3276 to
1f24fe9
Compare
|
It needs more work. Looks like wallet is also reading config files to figure out the ports. |
- Also removed hard coding of port range from CRDT
|
@garious could you pls review when you get a chance? |
garious
approved these changes
Aug 25, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
…olana-labs#920) Bumps [@rollup/plugin-commonjs](https://github.com/rollup/plugins) from 16.0.0 to 17.0.0. - [Release notes](https://github.com/rollup/plugins/releases) - [Commits](rollup/plugins@commonjs-v16.0.0...commonjs-v17.0.0) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.