Fix for repair dos #9056
Merged
Fix for repair dos #9056
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #9056 +/- ##
========================================
- Coverage 80.9% 80.9% -0.1%
========================================
Files 276 276
Lines 60894 60915 +21
========================================
+ Hits 49294 49304 +10
- Misses 11600 11611 +11 |
carllin
reviewed
Mar 26, 2020
carllin
reviewed
Mar 26, 2020
sakridge
changed the title
sakridge
force-pushed
the
repair-dos
branch
4 times, most recently
from
e52bcd2 to
947b1d6
Compare
|
|
|
@carllin please take a look when you get a chance. |
|
@sakridge, awesome! |
carllin
approved these changes
Apr 1, 2020
mergify bot
pushed a commit
that referenced
this pull request
Apr 1, 2020
(cherry picked from commit 7605f1f) # Conflicts: # core/src/serve_repair.rs
mergify bot
pushed a commit
that referenced
this pull request
Apr 1, 2020
(cherry picked from commit 7605f1f)
solana-grimes
pushed a commit
that referenced
this pull request
Apr 1, 2020
sakridge
added a commit
to sakridge/solana
that referenced
this pull request
Apr 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Repair dos can easily cause memory exhaustion and even high levels of repairs can cause a node to become delinquent.
Could be related to issues seen in tds with excessive repair requests:
#9009 (comment)
Summary of Changes
Empty the channel and drop extra repair messages, refactor the stats and prints so that they are better rate-limited.
Fixes #