This repository has been archived by the owner on Jan 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 4.5k
Align C and Rust handling of AccountInfos #8906
Merged
jackcmay
merged 1 commit into
solana-labs:master
from
jackcmay:align-rust-c-account-deserialization
Mar 17, 2020
Merged
Align C and Rust handling of AccountInfos #8906
jackcmay
merged 1 commit into
solana-labs:master
from
jackcmay:align-rust-c-account-deserialization
Mar 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 6, 2023
Open
This was referenced Jun 6, 2023
Open
This was referenced Jun 7, 2023
This was referenced Jun 8, 2023
This was referenced Jun 9, 2023
This was referenced Jun 12, 2023
This was referenced Sep 29, 2023
Open
Open
Open
Open
Open
Open
This was referenced Oct 6, 2023
Open
Open
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Unlike Rust, a C program cannot ask for less than the number of AccountInfos but can ask for more and still receive success
Summary of Changes
Flip the C AccountInfo deserialization behavior so programs can ask for less than what is available (they may not need/want it) but if they ask for more than deserialization fails.
Fixes #