-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use move semantics if not needed (bp #8793) #8803
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 6eb4973)
mergify
bot
added
the
automerge
Merge this Pull Request automatically once CI passes
label
Mar 11, 2020
solana-grimes
removed
the
automerge
Merge this Pull Request automatically once CI passes
label
Mar 11, 2020
💔 Unable to automerge due to CI failure |
thought you and @mvines decided this didn't need to go into 1.0. what changed? |
I see, okay, no objection. |
This was referenced Apr 13, 2023
This was referenced Apr 15, 2023
This was referenced Apr 15, 2023
Open
Open
This was referenced Apr 18, 2023
Open
This was referenced May 23, 2023
Open
Open
This was referenced May 29, 2023
Open
Open
This was referenced May 31, 2023
Open
This was referenced Jun 3, 2023
This was referenced Jun 3, 2023
Open
This was referenced Jun 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an automated backport of pull request #8793 done by Mergify
Mergify commands and options
More conditions and actions can be found in the documentation.
You can also trigger Mergify actions by commenting on this pull request:
@Mergifyio refresh
will re-evaluate the rules@Mergifyio rebase
will rebase this PR@Mergifyio backports <destination>
will backport this PR on<destination>
branchAdditionally, on Mergify dashboard you can:
Finally, you can contact us on https://mergify.io/