Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use move semantics if not needed (bp #8793) #8803

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Mar 11, 2020

This is an automated backport of pull request #8793 done by Mergify

Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR
  • @Mergifyio backports <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the simulator.

Finally, you can contact us on https://mergify.io/

@mergify mergify bot added the automerge Merge this Pull Request automatically once CI passes label Mar 11, 2020
@solana-grimes solana-grimes removed the automerge Merge this Pull Request automatically once CI passes label Mar 11, 2020
@solana-grimes
Copy link
Contributor

💔 Unable to automerge due to CI failure

@garious
Copy link
Contributor

garious commented Mar 12, 2020

thought you and @mvines decided this didn't need to go into 1.0. what changed?

@garious
Copy link
Contributor

garious commented Mar 12, 2020

@jackcmay

@jackcmay
Copy link
Contributor

@garious @mvines last post to the original PR says he supports bringing this into v1.0. Maybe I misread it

@jackcmay jackcmay self-assigned this Mar 12, 2020
@garious
Copy link
Contributor

garious commented Mar 12, 2020

I see, okay, no objection.

@t-nelson
Copy link
Contributor

t-nelson commented Mar 13, 2020

This and #8804 will go in as #8834

@t-nelson t-nelson closed this Mar 13, 2020
@mergify mergify bot deleted the mergify/bp/v1.0/pr-8793 branch March 13, 2020 06:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants