Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Simplify runtime account handling #8674

Merged
merged 2 commits into from
Mar 6, 2020
Merged

Simplify runtime account handling #8674

merged 2 commits into from
Mar 6, 2020

Conversation

jackcmay
Copy link
Contributor

@jackcmay jackcmay commented Mar 5, 2020

Problem

Unnecessary allocation and use of Option to hold PreAccounts

Summary of Changes

Cleanup and optimize those away along with some other cleanup

Fixes #

@jackcmay jackcmay added the noCI Suppress CI on this Pull Request label Mar 5, 2020
@jackcmay jackcmay force-pushed the simplify-runtime-account-handling branch from 01bb746 to f723c98 Compare March 5, 2020 21:25
@jackcmay jackcmay added CI Pull Request is ready to enter CI and removed noCI Suppress CI on this Pull Request labels Mar 5, 2020
@solana-grimes solana-grimes removed the CI Pull Request is ready to enter CI label Mar 5, 2020
@codecov
Copy link

codecov bot commented Mar 5, 2020

Codecov Report

Merging #8674 into master will decrease coverage by <.1%.
The diff coverage is 100%.

@@           Coverage Diff            @@
##           master   #8674     +/-   ##
========================================
- Coverage    80.1%   80.1%   -0.1%     
========================================
  Files         260     260             
  Lines       56328   56328             
========================================
- Hits        45134   45130      -4     
- Misses      11194   11198      +4

@jackcmay jackcmay requested a review from garious March 5, 2020 23:18
garious
garious approved these changes Mar 6, 2020
View reviewed changes
Copy link
Contributor

@garious garious left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

neato

@jackcmay jackcmay merged commit 8ad6a87 into solana-labs:master Mar 6, 2020
@jackcmay jackcmay deleted the simplify-runtime-account-handling branch March 6, 2020 00:17
This was referenced Apr 13, 2023
Open
Open
Open
This was referenced Apr 15, 2023
Open
Open
Open
This was referenced Apr 15, 2023
Open
Open
Open
Open
Open
Open
Open
Open
This was referenced Apr 18, 2023
Open
Open
Open
Open
This was referenced May 22, 2023
Open
Open
@snyk-bot snyk-bot mentioned this pull request May 22, 2023
Open
This was referenced May 23, 2023
Open
Open
Open
Open
Open
Open
This was referenced May 29, 2023
Open
Open
Open
Open
Open
Open
This was referenced May 31, 2023
Open
Open
Open
Open
Open
Open
This was referenced Jun 3, 2023
Open
Open
Open
This was referenced Jun 3, 2023
Open
Open
Open
This was referenced Jun 5, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@garious garious garious approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jackcmay @garious @solana-grimes