Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep GenesisConfig binary compatible with v0.23 #8617

Merged
merged 1 commit into from
Mar 4, 2020

Conversation

mvines
Copy link
Member

@mvines mvines commented Mar 4, 2020

This,

#[serde(skip)]
, caused GenesisConfig to not longer be compatible with v0.23. Rather than rewriting genesis for TdS and SLP and going into a long diatribe with busloads of people to justify why the genesis hash for TdS and SLP changed, sneak in a dummy u64 field to make everything line up again.

cc: @t-nelson

@mvines mvines added v1.0 automerge Merge this Pull Request automatically once CI passes labels Mar 4, 2020
@codecov
Copy link

codecov bot commented Mar 4, 2020

Codecov Report

Merging #8617 into master will decrease coverage by <.1%.
The diff coverage is 0%.

@@           Coverage Diff            @@
##           master   #8617     +/-   ##
========================================
- Coverage      80%     80%   -0.1%     
========================================
  Files         257     257             
  Lines       55742   55743      +1     
========================================
- Hits        44605   44604      -1     
- Misses      11137   11139      +2

@solana-grimes solana-grimes merged commit d3b458d into solana-labs:master Mar 4, 2020
mergify bot pushed a commit that referenced this pull request Mar 4, 2020
solana-grimes pushed a commit that referenced this pull request Mar 4, 2020
@t-nelson
Copy link
Contributor

t-nelson commented Mar 4, 2020

Oof, 💩! Sorry, I totally forgot about that one 🤦‍♂️

@mvines
Copy link
Member Author

mvines commented Mar 4, 2020

np, I reviewed the code too :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge Merge this Pull Request automatically once CI passes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants