Skip to content
This repository has been archived by the owner on Jan 22, 2025. It is now read-only.

Add mechanism to load v0.22.3 snapshots on newer Solana versions #7917

Merged
merged 1 commit into from
Jan 22, 2020

Conversation

mvines
Copy link
Contributor

@mvines mvines commented Jan 22, 2020

Once #7801 lands, snapshots produced by v0.22.3 (ie, version that SLP was running) will not be loadable on v0.22.4. As a stopgap measure until #7738:

  1. Add a version text file to the snapshot archive. Snapshots without this version file are assumed to be "v0.22.3"-based.
  2. Snapshots that are of the same version as the currently running code are compatible
  3. Snapshots that are "v0.22.3"-based can be loaded on new versions using a LegacyBank0223 struct

NB: This will be landed on v0.22 first then cherry-picked up to master

@mvines mvines requested a review from ryoqun January 22, 2020 06:20
@mvines
Copy link
Contributor Author

mvines commented Jan 22, 2020

@ryoqun - what do you think?

@codecov
Copy link

codecov bot commented Jan 22, 2020

Codecov Report

Merging #7917 into v0.22 will decrease coverage by 16%.
The diff coverage is 4.1%.

@@           Coverage Diff            @@
##           v0.22   #7917      +/-   ##
========================================
- Coverage   80.9%   64.9%   -16.1%     
========================================
  Files        243     243              
  Lines      51790   64573   +12783     
========================================
+ Hits       41943   41948       +5     
- Misses      9847   22625   +12778

@mvines mvines force-pushed the snap22 branch 2 times, most recently from cf9bb58 to b121602 Compare January 22, 2020 16:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants