Display max TPS from all nodes at end of client demo #716
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pgarg66
commented
Jul 19, 2018
pgarg66
commented
- Also lists node with 0 TPS and overall average TPS
- Also lists node with 0 TPS and overall average TPS
sakridge
reviewed
Jul 20, 2018
src/bin/client-demo.rs
Outdated
| let mut total_maxes = 0.0; | ||
| for (max, txs, sock) in maxes.read().unwrap().iter() { | ||
| println!("Node:{}, Max TPS: {:.2}", *sock, *max); | ||
| if *max == 0.0 { |
There was a problem hiding this comment.
Use txs == 0 here? exact compare with float makes me cringe, although probably ok here.
There was a problem hiding this comment.
I'll change it to txs == 0
pgarg66
force-pushed
the
client-demo-max-tps
branch
from
667dd15 to
5db8a7a
Compare
mvines
approved these changes
Jul 20, 2018
src/bin/client-demo.rs
Outdated
| @@ -33,9 +33,14 @@ use std::thread::JoinHandle; | |||
| use std::time::Duration; | |||
| use std::time::Instant; | |||
|
|
|||
| pub struct NodeStats { | |||
| pub tps: f64, | |||
| pub tx: u64, | |||
There was a problem hiding this comment.
can you please document these two fields? I can mostly guess what they mean but I'd rather not guess :)
pgarg66
force-pushed
the
client-demo-max-tps
branch
from
5db8a7a to
9bf6390
Compare
35359595
pushed a commit
to 35359595/solana
that referenced
this pull request
Apr 10, 2024
* default staked client in LocalCluster * fix underflow
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Apr 11, 2024
…#716) (solana-labs#723) * default staked client in LocalCluster (solana-labs#716) * default staked client in LocalCluster * fix underflow (cherry picked from commit e91a5e2) # Conflicts: # local-cluster/tests/local_cluster.rs * resolve conflicts --------- Co-authored-by: Andrew Fitzgerald <[email protected]>
yihau
pushed a commit
that referenced
this pull request
Apr 11, 2024
* default staked client in LocalCluster (#716) * default staked client in LocalCluster * fix underflow (cherry picked from commit e91a5e2) # Conflicts: # local-cluster/tests/local_cluster.rs * resolve conflicts --------- Co-authored-by: Andrew Fitzgerald <[email protected]>
yihau
pushed a commit
that referenced
this pull request
Apr 11, 2024
* default staked client in LocalCluster (#716) * default staked client in LocalCluster * fix underflow (cherry picked from commit e91a5e2) # Conflicts: # local-cluster/tests/local_cluster.rs * resolve conflicts --------- Co-authored-by: Andrew Fitzgerald <[email protected]>
lijunwangs
pushed a commit
to lijunwangs/solana
that referenced
this pull request
Apr 24, 2024
…#716) (solana-labs#724) * default staked client in LocalCluster (solana-labs#716) * default staked client in LocalCluster * fix underflow (cherry picked from commit e91a5e2) # Conflicts: # local-cluster/tests/local_cluster.rs * resolve conflicts --------- Co-authored-by: Andrew Fitzgerald <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.