Create development vs production environment hooks into net scripts #6974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danpaul000
force-pushed
the
slp
branch
3 times, most recently
from
fbc30db to
1f1a49f
Compare
Codecov Report
@@ Coverage Diff @@
## master #6974 +/- ##
========================================
+ Coverage 78.8% 78.9% +0.1%
========================================
Files 222 221 -1
Lines 42818 42675 -143
========================================
- Hits 33766 33702 -64
+ Misses 9052 8973 -79 |
mvines
reviewed
Nov 15, 2019
mvines
previously approved these changes
Nov 15, 2019
genesis/src/main.rs
Outdated
| .help("Configure the cluster for development mode where all features are available at epoch 0"), | ||
| Arg::with_name("operating_mode") | ||
| .long("operating-mode") | ||
| .value_name("\"development\"|\"softlaunch\"") |
There was a problem hiding this comment.
|
@mvines should this have gone into v0.20 as well? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
We have no way to set the SLP "production" restricted environment from the CI/net scripts.
Summary of Changes
Allow development vs production environment mode to be explicitly set through the stack.
Partial solution to #6397