Check that transaction fee-payer is a debitable account

[CriesofCarrots]

Problem

Currently, all credit-debit checks happen inside message_processor::process_message. However, transaction fees get charged upstream in accounts::load_tx_accounts. This means that if a credit-only account is the first signer, it gets successfully charged the fee if it can afford it, potentially adding non-determinism to the chain.

Summary of Changes

• Add debitable check of first signer account (fee payer) to sigveryify::do_get_offsets so that it gets executed before any signature verification or transaction deserialization occurs
• Also updates relevant solana-cli stake and vote transactions to use Transaction::new_signed_with_payer to ensure they don't fail this new processing.

Fixes #6339

[codecov]

Codecov Report

Merging #6454 into master will decrease coverage by 1.1%.
The diff coverage is 58.7%.

@@           Coverage Diff            @@
##           master   #6454     +/-   ##
========================================
- Coverage    79.9%   78.7%   -1.2%     
========================================
  Files         217     217             
  Lines       41340   41974    +634     
========================================
+ Hits        33039   33071     +32     
- Misses       8301    8903    +602

[garious]

Great find and patch!

Pull request has been modified.