Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetch blobs instead of packets in the RPU #631

Closed
wants to merge 1 commit into from

Conversation

garious
Copy link
Contributor

@garious garious commented Jul 15, 2018

Recommended approach by @aeyakovenko. TPU's FetchStage should be the
only special case.

@garious garious requested a review from aeyakovenko July 15, 2018 19:23
@garious
Copy link
Contributor Author

garious commented Jul 15, 2018

@rob-solana, is it possible that test_leader_restart_validator_start_from_old_ledger would fail due to this change? I'm not able to reproduce the failure locally.

@rob-solana
Copy link
Contributor

I don't see how this change would affect those tests.

@garious garious force-pushed the simplify-rpu branch 2 times, most recently from 16f3155 to 6686953 Compare July 20, 2018 17:12
@garious
Copy link
Contributor Author

garious commented Jul 21, 2018

Status of this PR: This change consistently breaks the test_leader_restart_validator_start_from_old_ledger integration test in (and only in) the perf configuration, @rob-solana and I don't know why, and I have not had time to debug.

@sakridge, this PR is low priority, but you're in best position to glance at the change and guess why it might affect the cuda build. If nothing stands out as obvious, I'll dig deeper. I'm hoping an artifact of fixing this PR will be a cuda/erasure unit test and/or a lower-level restart_validator unit test.

@garious garious force-pushed the simplify-rpu branch 2 times, most recently from 2dc82fa to dab1cae Compare August 1, 2018 16:15
Recommended approach by @aeyakovenko. TPU's FetchStage should be the
only special case.
@garious garious added the work in progress This isn't quite right yet label Aug 5, 2018
@garious garious self-assigned this Aug 13, 2018
@garious
Copy link
Contributor Author

garious commented Aug 20, 2018

Closing this under the assumption that we end up deleting the whole RPU instead. @CriesofCarrots, fyi.

@garious garious closed this Aug 20, 2018
vkomenda pushed a commit to vkomenda/solana that referenced this pull request Aug 29, 2021
yihau pushed a commit to yihau/solana that referenced this pull request Apr 10, 2024
…rewards (solana-labs#631)

* Remove rewards-interval-related check_account_access implementation

* Move RewardsInterval to tests module

* Update test to new StakeProgram functionality
vovkman pushed a commit to helius-labs/solana that referenced this pull request Aug 20, 2024
techiepriyansh pushed a commit to ChorusOne/solana that referenced this pull request Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
work in progress This isn't quite right yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants