-
Notifications
You must be signed in to change notification settings - Fork 4.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test-drive Criterion.rs #576
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will make it available to third party benchmarking tools.
garious
requested review from
sakridge,
aeyakovenko,
mvines,
ericlwilliams,
pgarg66 and
rob-solana
July 10, 2018 22:51
mvines
reviewed
Jul 10, 2018
benches/bank.rs
Outdated
let tx = Transaction::new(&rando0, rando1.pubkey(), 1, last_id); | ||
assert!(bank.process_transaction(&tx.clone()).is_ok()); | ||
|
||
// Finally, return a the transaction to benchmark. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "return a the transaction"
rob-solana
approved these changes
Jul 10, 2018
mvines
approved these changes
Jul 10, 2018
vkomenda
pushed a commit
to vkomenda/solana
that referenced
this pull request
Aug 29, 2021
behzadnouri
pushed a commit
to behzadnouri/solana
that referenced
this pull request
Apr 12, 2024
* change read-only-cache to keyed on pubkey only * implement review feedbacks --------- Co-authored-by: HaoranYi <[email protected]>
buffalojoec
pushed a commit
to buffalojoec/solana
that referenced
this pull request
Apr 16, 2024
* change read-only-cache to keyed on pubkey only * implement review feedbacks --------- Co-authored-by: HaoranYi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://japaric.github.io/criterion.rs/book/criterion_rs.html
We gain:
We lose:
#[bench]
Sample command-line output:
Sample output from the HTML report:
bench_process_transaction.pdf
cc: #283